Enable intrinsic function for configs#640
Conversation
This commit allows to use intrinsic function for waf and xray
This proved to be the wrong approach: Resolvers are supposed to return only data - not change the response. This becomes problematic if a response triggers many resolvers (e.g. a search request), which would return lots of headers.
|
Thanks for this, @ronnyroeller — and apologies it sat for so long. 🙏 The codebase has moved on quite a bit since this was opened (the v2 rewrite and the recent AWS SDK v3 migration), so rather than ask you to resolve the conflicts, I've rebased your change onto current master in #713 and credited you as co-author. It keeps your core idea — a booleanOrIntrinsicFunction schema definition alongside the existing stringOrIntrinsicFunction — and applies it to the fields that still exist and pass straight through to CloudFormation: openIdConnectConfig.issuer, xrayEnabled, and logging.excludeVerboseContent. One adjustment worth noting: wafEnabled from the original no longer exists (it's now waf.enabled), and I deliberately left it — along with logging.enabled, caching.enabled, and domain.enabled — as a plain boolean. Those are synth-time toggles that decide in JS whether the resource is generated at all, so a deploy-time intrinsic can't drive them. |
3 participants
This PR enables intrinsic function usage for
xrayEnabled,wafEnabledandopenIdConnectConfig.issuerfields.Fixes: #638